Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated SequenceRunStateChange Event schema with proper envelope #29

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Updated SequenceRunStateChange Event schema with proper envelope #29

merged 1 commit into from
Jun 15, 2023

Conversation

victorskl
Copy link
Member

@victorskl victorskl commented Jun 14, 2023 •
edited
Loading

  • Wrapped into proper Event envelope
  • Refactored domain event payload into component schema
    definition SequenceRunStateChange
  • Namespaced X-header event source to orcabus.srm

@victorskl
Updated SequenceRunStateChange Event schema with proper envelope
d11e3b0 
* Wrapped into proper Event envelope
* Refactored domain event payload into component schema
  definition `SequenceRunStateChange`
* Namespaced X-header event source to `orcabus.srm`
@victorskl victorskl changed the base branch from main to implement-sequence-run-manager June 14, 2023 09:47
@victorskl victorskl changed the title update event schema sequence run state change Updated SequenceRunStateChange Event schema with proper envelope Jun 14, 2023
@victorskl victorskl self-assigned this Jun 14, 2023
@victorskl victorskl added this to the Release 0.1.0 milestone Jun 14, 2023
@victorskl victorskl added the feature New feature label Jun 14, 2023
@victorskl
Copy link
Member Author

OrcaBus V1: Implement SequenceRunManager microservice app

reisingerf
reisingerf approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
A bit too many parameters mandatory, but we can change that later.

@victorskl victorskl merged commit bd4d9f1 into implement-sequence-run-manager Jun 15, 2023
@victorskl victorskl deleted the update-event-schema-sequence-run-state-change branch June 15, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reisingerf reisingerf reisingerf approved these changes

Assignees

@victorskl victorskl

Labels
change request feature New feature
Projects
None yet
Milestone
Release 0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@victorskl @reisingerf