Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation on Event Schema and Namespace guide #307

Merged
merged 1 commit into from
May 21, 2024

Conversation

victorskl
Copy link
Member

  • Improved repo landing README.md

@victorskl victorskl self-assigned this May 18, 2024
@victorskl victorskl linked an issue May 18, 2024 that may be closed by this pull request
@victorskl victorskl added the documentation Improvements or additions to documentation label May 18, 2024
Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(minor comments)

### Multiple Service Schemas

- Multiple services may publish the same or similar schema due to similarity of their domain modelling aspect.
- The event schema discriminator is the event `source` property of the event message instance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps mention 'detail-type' here?
The source is only one dimension and a service can also emit different events types, i.e. multiple detail-types from the same source. Both together define the event schema.


## Namespace

Service namespaces are for filtering Event Rule purpose. This is used in event `source` property when service emits messages. It denotes where the message is originating from. The convention follows reverse domain name. We follow "compat" format of [CDK stack directory name](../../lib/workload/stateless/stacks). i.e. Removing dash character from kebab-case.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, also use detail-type (see naming of examples)

@brainstorm brainstorm self-requested a review May 20, 2024 02:15
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@victorskl
Copy link
Member Author

We are going to rearrange this REAME a little bit in next PR. Merging it as-is for now and, doing minor edit in next PR.

Merging...

@victorskl victorskl merged commit e425488 into main May 21, 2024
1 check passed
@victorskl victorskl deleted the add-doc-event-schema-guide branch May 21, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and finalise event schema
4 participants