Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filemanager): add Parquet and Orc support to inventory #310

Merged
merged 1 commit into from
May 20, 2024
Merged

feat(filemanager): add Parquet and Orc support to inventory #310

merged 1 commit into from
May 20, 2024

Conversation

mmalenic
Copy link
Member

Related to #219 and #304

Some left overs from the previous PR.

Changes

  • Add support for Parquet and Orc for the filemanager inventory function

@mmalenic mmalenic self-assigned this May 20, 2024
@mmalenic mmalenic changed the title feat(filemanager): add orc and parquet support feat(filemanager): add Parquet and Orc support May 20, 2024
@mmalenic mmalenic requested a review from brainstorm May 20, 2024 05:44
@mmalenic mmalenic added the feature New feature label May 20, 2024
@mmalenic mmalenic linked an issue May 20, 2024 that may be closed by this pull request
filemanager: sync database to current S3 state #219
Closed
@mmalenic mmalenic changed the title feat(filemanager): add Parquet and Orc support feat(filemanager): add Parquet and Orc support to inventory May 20, 2024
brainstorm
brainstorm approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, didn't expect that ORC support too, kudos!

@mmalenic
Copy link
Member Author

mmalenic commented May 20, 2024 •
edited
Loading

Woah, didn't expect that ORC support too, kudos!

They both get deserialized into Arrow, just a different reader. So I included it as it's effort-wise the same.

@mmalenic mmalenic merged commit 349cb06 into main May 20, 2024
1 check passed
@mmalenic mmalenic deleted the feat/filemanager-inventory branch May 20, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees

@mmalenic mmalenic

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filemanager: sync database to current S3 state
2 participants
@mmalenic @brainstorm