Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filemanager delete marker #321

Merged
merged 2 commits into from
May 27, 2024
Merged

fix: filemanager delete marker #321

merged 2 commits into from
May 27, 2024

Conversation

mmalenic
Copy link
Member

Closes #316

Changes

  • Tracks delete markers in the database and considers a delete marker being created and permanently deleted as a single record in the database.
  • Removes coalesced columns in the update_reordered queries, because null values should also be reprocessed into separate database entries.
  • Adds tests for these fixes.

@mmalenic mmalenic self-assigned this May 24, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager fix labels May 24, 2024
@mmalenic mmalenic requested a review from brainstorm May 24, 2024 03:52
@mmalenic mmalenic force-pushed the fix/filemanager-delete-marker branch from 0140817 to 79dfd23 Compare May 24, 2024 03:53
brainstorm
brainstorm approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting gotcha described in issue #316 and the implementation seems sound, kudos!

@brainstorm brainstorm merged commit 12f7ae5 into main May 27, 2024
5 checks passed
@brainstorm brainstorm deleted the fix/filemanager-delete-marker branch May 27, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees

@mmalenic mmalenic

Labels
filemanager an issue relating to the filemanager fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filemanager: consider s3:ObjectRemoved:DeleteMarkerCreated events when versioning is enabled
2 participants
@mmalenic @brainstorm