Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User reference will always start with 'umccr__automated__workflowName` #345

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

alexiswl
Copy link
Member

@alexiswl alexiswl commented Jun 6, 2024

We cannot rely on the pipeline ID (since a user might want a different pipeline id to be run),
We cannot rely on the pipeline Code (since ctDNA Pipeline codes are inconsistent between versions)

Instead the workflow run name (or userRefence) generated will always be umccr_automated__${workflow_name}.

Resolves #344

Can confirm this works by using an eventSandbox

image

We cannot rely on the pipeline ID (since a user might want a different pipeline id to be run),
We cannot rely on the pipeline Code (since ctDNA Pipeline codes are inconsistent between versions)
@alexiswl alexiswl merged commit a1c134f into main Jun 6, 2024
5 checks passed
@alexiswl alexiswl deleted the bugfix/event-rule-icav2-filter-on-workflow-name branch June 6, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICA Workflow Handler SFN Construct should use pipelineCode in their event filters
2 participants