Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filemanager): make HeadObject optional #355

Merged
merged 3 commits into from
Jun 18, 2024
Merged

fix(filemanager): make HeadObject optional #355

merged 3 commits into from
Jun 18, 2024

Conversation

mmalenic
Copy link
Member

Closes #354

Changes

  • Makes the HeadObject call for ingesting events optional.

@mmalenic mmalenic self-assigned this Jun 17, 2024
@mmalenic mmalenic added the fix label Jun 17, 2024
@brainstorm
Copy link
Member

Ah, good consistency catch... so we now ignore but log because nothing else can be done I guess 👍

@mmalenic
Copy link
Member Author

Update

  • Also added permissions for the ingest Lambda function to access pipeline cache buckets

@mmalenic mmalenic requested a review from reisingerf June 17, 2024 23:02
victorskl
victorskl approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just heads up. Conceptually, HeadObject ops can determine the object status details once it get moved into Glacier Deep Archive tier or, objects from archival bucket.

@mmalenic
Copy link
Member Author

Another update

  • I've added a NamedLamdbaRole construct to support creating named roles.
  • Add warning for a lack of permissions.
  • Fixed CDK nag.

@mmalenic mmalenic mentioned this pull request Jun 18, 2024
Merged
@mmalenic mmalenic merged commit ddb107a into main Jun 18, 2024
5 checks passed
@mmalenic mmalenic deleted the fix/filemanager-head-object branch June 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

@victorskl victorskl victorskl approved these changes

@reisingerf reisingerf reisingerf approved these changes

Assignees

@mmalenic mmalenic

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filemanager: HeadObject causes error when there are no permissions
4 participants
@mmalenic @brainstorm @victorskl @reisingerf