Implemented Sequence Run Manager BSSH event processing #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We will be still subscribing to ICA v1 ENS for BSSH event * Our internal entity model as well as domain model are not specific to BSSH * SequenceDomain struct wrap Sequence entity instance and its purpose is to handle all translation between entity to domain event schema semantic * EventBus schema auto-generated Code Bindings `sequencerunstatechange` is part of domain package. Its internals should be interfaced through SequenceDomain * Made a good unit test coverage on marshall/unmarshall and all aspect of serde * Made `DJANGO_SETTINGS_MODULE` config mandatory instead of defaulting to base * Added documentation
brainstorm
approved these changes
Jun 23, 2023
williamputraintan
approved these changes
Jun 27, 2023
|
Thanks all, merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle all translation between entity to domain event schema semantic
sequencerunstatechangeis partof domain package. Its internals should be interfaced through SequenceDomain
DJANGO_SETTINGS_MODULEconfig mandatory instead of defaulting to base