Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support s3 uris and bump wrapica to 2.27.1 #444

Closed
wants to merge 2 commits into from
Closed

Support s3 uris and bump wrapica to 2.27.1 #444

wants to merge 2 commits into from

Conversation

alexiswl
Copy link
Member

@alexiswl alexiswl commented Aug 3, 2024 •
edited
Loading

TODO

  • Determine if development service user can access underlying storage configurations

@alexiswl alexiswl requested a review from victorskl August 3, 2024 06:19
@alexiswl alexiswl self-assigned this Aug 3, 2024
@victorskl
Copy link
Member

Checking on this...

@victorskl victorskl linked an issue Aug 4, 2024 that may be closed by this pull request
Move from icav2 uris to s3 uris for events #436
Closed
victorskl
victorskl approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so far looking good. Tick the box, just in case, you'd like to push it through.

@alexiswl alexiswl marked this pull request as ready for review August 5, 2024 00:28
@alexiswl
Copy link
Member Author

alexiswl commented Aug 5, 2024

This is working now @reisingerf has shared the dev-cache credentials

@alexiswl
Copy link
Member Author

alexiswl commented Aug 6, 2024

Superseded by #451, forgot I hadn't merged this

@alexiswl alexiswl closed this Aug 6, 2024
alexiswl added a commit that referenced this pull request Aug 6, 2024
@alexiswl
Update with changes from s3 branch that I forgot hadn't yet been merged
ffdc6ad 
Taken from #444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorskl victorskl victorskl approved these changes

Assignees

@alexiswl alexiswl

Labels
change request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move from icav2 uris to s3 uris for events
2 participants
@alexiswl @victorskl