Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change(WorkflowRunManager): add more query and search terms #540

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

raylrui
Copy link
Contributor

@raylrui raylrui commented Sep 12, 2024

  1. add status query params for filter by the latest status
  2. add libraryId and orcabusId in the search terms for group workflow runs

example:
http://localhost:8000/api/v1/workflowrun/?search=lib.01J5S9CFX5P69S4KZRQGDFKV1N&status=GENERATING_OUTPUTS
http://localhost:8000/api/v1/workflowrun/?search=L2400255&status=READY

@raylrui raylrui self-assigned this Sep 12, 2024
@raylrui raylrui added the feature New feature label Sep 12, 2024
@raylrui raylrui marked this pull request as ready for review September 13, 2024 01:43
Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we'll run into clashes / limits with "L" for libraries, but happy to give it a go.

@raylrui
Copy link
Contributor Author

raylrui commented Sep 13, 2024

yes, I am also think of that, what I thought is we can combine all search results in different scope and return them together.
I will update that later after some testing...

@reisingerf
Copy link
Member

All good!

@raylrui
Copy link
Contributor Author

raylrui commented Sep 16, 2024

default "fuzzy" search" will be removed, and new search terms will constraint to (worfkflow run name, comment, library_id, orcabus_id, workflow name), which will be defined by us

In UI, there will be a tooltips to show available search items
image

@raylrui
Copy link
Contributor Author

raylrui commented Sep 16, 2024

No model or migrate added. Merge now ......

@raylrui raylrui merged commit a0facb4 into main Sep 16, 2024
6 checks passed
@raylrui raylrui deleted the feat/add-query-search-terms-of-workflowrun branch September 16, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants