Filemanager: fix ingestion/deployment #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid any manual intervention while editing code
```json
{"message":"Error(\"missing field `Records`\", line: 1, column: 221)"}
```
Fixed S3Error(`unhandled error`)... CDK creates the bucket fine now with the required event hooks.
Co-Authored-by: @victorskl
…erialization error...
…sites by making its own sub-section
…DS's Postgress serverlessV2, thanks @andrewpatto for https:/elsa-data/aws-infrastructure inspiration... synths but there are quite a few things to tweak/fix I reckon #reviewthis plz?
|
Since we removed LocalStack from the mix, the current CI will most likely fail, btw. |
mmalenic
approved these changes
Dec 14, 2023
lib/workload/stateful/filemanager/deploy/stack/filemanager_stack.ts
Outdated
Show resolved
Hide resolved
lib/workload/stateful/filemanager/deploy/stack/filemanager_stack.ts
Outdated
Show resolved
Hide resolved
|
@mmalenic I think that you approved this PR too fast :P Can you try to deploy yourself (against dev account) and let me know why the RDS construct is not showing up in neither cdk synth/deploy? |
|
Sure, I'll have a look. I guess we're using Aurora over plain RDS because it's more managed/simpler? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at a LocalStack-less, AWS-deployable filemanager meso-service (since it's stateful w/ database et al).
Goal for this getting merged is Victor being able to deploy/operate/develop on it from the get-go, without local errors.
Will fix issues: #70 #71 ... at least