Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript is pure commonjs #112

Closed
wants to merge 1 commit into from
Closed

fix: typescript is pure commonjs #112

wants to merge 1 commit into from

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Oct 27, 2023

close #101

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

⚠️ No Changeset found

Latest commit: 8dd0cfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin
Copy link
Member Author

JounQin commented Oct 27, 2023

import sonar from 'eslint-plugin-sonar'

console.log(sonar)
import { rules as rules$4 } from 'eslint-plugin-react';
         ^^^^^
SyntaxError: Named export 'rules' not found. The requested module 'eslint-plugin-react' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'eslint-plugin-react';
const { rules: rules$4 } = pkg;

@JounQin
Copy link
Member Author

JounQin commented Dec 27, 2023

fixed by #113

@JounQin JounQin closed this Dec 27, 2023
@JounQin JounQin deleted the fix/esm branch December 27, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant