Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more checks into checkPhase #13

Closed
KaiserKarel opened this issue May 17, 2023 · 2 comments
Closed

Move more checks into checkPhase #13

KaiserKarel opened this issue May 17, 2023 · 2 comments
Labels
S-wontfix Status: This will not be worked on

Comments

@KaiserKarel
Copy link
Contributor

Right now we are defining many top-level checks, which is quite noisy. Derivations export a checkPhase, which means that for each derivation, we could verify the integrity of that output without cluttering the global namespace.

@KaiserKarel
Copy link
Contributor Author

Decided on for now holding off, as we'd like to quickly observe failing tests in CI. Probably around 100 checks we ought to switch. A nice pattern is pulling in the checks in the checkPhase to force evaluation:

unionvisor = crane.stable.buildPackage (commonArgs // { 
        doCheck = true;
        checkPhase = ''
          ls -a ${checks.unionvisor-clippy}
        '';
      });

@KaiserKarel KaiserKarel added the S-wontfix Status: This will not be worked on label May 17, 2023
@benluelo
Copy link
Contributor

related: #525

@cor cor closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-wontfix Status: This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants