Update sunburst #36
Merged
Update sunburst #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmesuere
reviewed
Jan 22, 2021
src/color/ColorUtils.ts
Outdated
| @@ -0,0 +1,22 @@ | |||
| import * as d3 from "d3"; | |||
There was a problem hiding this comment.
I don't know if it would make a difference here, but maybe only import the single function that is used?
There was a problem hiding this comment.
I resolved this in the most recent commit :)
bmesuere
approved these changes
Jan 22, 2021
|
Part of the changes in this PR are based upon the work done by @MaybeJustJames in #36! Thank you, @MaybeJustJames, for your contribution to our codebase! |
This was referenced Feb 16, 2021
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the sunburst visualization from D3 v3 to D3 v6, replaces JavaScript with TypeScript and does no longer require jQuery as a dependency.
Functionality of this sunburst is completely equivalent to the original sunburst, but some performance improvements have been made under the hood. These result in a significant speedup for complex sunburst visualizations.
A sunburst with ~6000 nodes takes about 15-16 seconds to render using the original sunburst. The new version brings this time down to about 0.5 seconds. This is a comparison between both versions for future reference (left is v2, right is v1):
Sunburst.v1.vs.v2.mp4