Update ruff to v6.8 and many typos #2548
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Thanks @gdevos010 for this PR, looks good overall.
Can you please revert the changes to the images in the notebooks? Also, found some changes in the code that might cause some issues.
Also, we need to make sur follow the migrations instruction from 0.3.6 to 0.6.8 to avoid issues.
| @@ -458,12 +458,12 @@ def ensemble( | |||
| ensembled = [ | |||
| self.regression_model.predict( | |||
| n=len(prediction), | |||
| series=serie, | |||
| series=series, | |||
There was a problem hiding this comment.
Please revert this one, having both the element and iterable called series does not look good.
| serie = pd.Series(data=values, index=time_range_MS) | ||
| ts = TimeSeries.from_series(pd_series=serie) | ||
| series = pd.Series(data=values, index=time_range_MS) | ||
| ts = TimeSeries.from_series(pd_series=series) |
There was a problem hiding this comment.
Let's revert this one as well.
| @@ -116,9 +116,9 @@ def get_feature_times_target( | |||
| Helper function called by `get_feature_times` that extracts all times within a | |||
| `target_series` that can be used to create a feature and label. More specifically, | |||
| we can create features and labels for times within `target_series` that have *both*: | |||
| 1. At least `max_lag = -min(lags)` values preceeding them, since these preceeding | |||
| 1. At least `max_lag = -min(lags)` values presceeding them, since these preceeding | |||
There was a problem hiding this comment.
| 1. At least `max_lag = -min(lags)` values presceeding them, since these preceeding | |
| 1. At least `max_lag = -min(lags)` values preceding them, since these preceding |
There was a problem hiding this comment.
Please revert the changes to the images
There was a problem hiding this comment.
Please revert the changes to the images
There was a problem hiding this comment.
Revert changes to images
Checklist before merging this PR:
Fixes #2547.
Summary
update to ruff v6.8
fixed many typos
Other Information