Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you start maintaining "github releases"? #1452

Closed
Myz opened this issue Jun 12, 2017 · 15 comments
Closed

Could you start maintaining "github releases"? #1452

Myz opened this issue Jun 12, 2017 · 15 comments
Assignees

Comments

@Myz
Copy link
Contributor

Myz commented Jun 12, 2017

It would be very nice for our internal build tool to have the releases as a "github release" so out bot can parse the /releases page to determine the latest package.

https:/universal-ctags/ctags/releases

Might this be possible or is it too much effort?
Thanks in advance.

@ninewise
Copy link

See #1038, #661 and #1272.

@Myz
Copy link
Contributor Author

Myz commented Jun 12, 2017

Thanks, at some day I will learn how to use the search bar, sorry....

@Myz Myz closed this as completed Jun 12, 2017
@Myz
Copy link
Contributor Author

Myz commented Mar 6, 2019

Since you are using the packcc as a direct dependency to the ctags build, it might be necessary to have source releases that bundle a fully buildable archive.

If you download the bundled zip archive from the github page now, extract it and then try to configure and build it, it will not work because the autogen.sh contains this git commands now.

How are your plans on this?

@Myz Myz reopened this Mar 6, 2019
@masatake
Copy link
Member

masatake commented Mar 6, 2019

Does adding --without-packcc option to configure help you?

@Myz
Copy link
Contributor Author

Myz commented Mar 6, 2019 via email

@masatake masatake self-assigned this Mar 6, 2019
@masatake
Copy link
Member

masatake commented Mar 8, 2019

I would like to know a bit more details of the build process you run.
After getting a zip file of ctags, do you run autogen.sh before running configure?
In that case, you will get packcc because autogen.sh runs git-submodule commands.
I guess you run something custom scripts instead of autogen.sh.

I would like to think more about what area in ctags I should fix.

@k-takata
Copy link
Member

k-takata commented Mar 8, 2019

git-submodule commands won't work when getting a zip file, because .git doesn't exist.
How about using git-subtree command instead of git-submodule?

@masatake
Copy link
Member

masatake commented Mar 8, 2019

@k-takata, thank you.
At a glance, it looks good. Maybe it is better than adding --without-packcc option to ctags.
I will study more about git-subtree in this weekend.

...The weekend queue becomes longer and longer.

@k-takata
Copy link
Member

k-takata commented Mar 8, 2019

Example:
1st time:

$ git submodule deinit -f misc/packcc
$ git rm -f misc/packcc
$ git commit -m 'Delete packcc'
$ git subtree add --prefix misc/packcc https:/universal-ctags/packcc.git master --squash

When you want to import the updated packcc:

$ git subtree pull --prefix misc/packcc https:/universal-ctags/packcc.git master --squash

@masatake
Copy link
Member

masatake commented Mar 8, 2019

@k-takata, can I ask you to make a pull request for it?

I will add your suggestion:

$ git subtree pull --prefix misc/packcc https:/universal-ctags/packcc.git master --squash

as what developers should do to ... README.md of packcc side. I will do it after merging your change.

@k-takata
Copy link
Member

k-takata commented Mar 8, 2019

I will create a PR later.
How about adding a script for git-subtree-pull? E.g. misc/pull-packcc.sh:

#!/bin/sh

# Update to the latest packcc
#
# Copyright (C) 2019 Universal Ctags Team
# License: GPL 2 or later

cd $(git rev-parse --show-toplevel)
git subtree pull --prefix misc/packcc https:/universal-ctags/packcc.git master --squash

@Myz
Copy link
Contributor Author

Myz commented Mar 8, 2019

@masatake Our build process is rather simple. We have set up a script that downloads the zip bundled archive of the master branch, extracts and configures it after using the ./autogen.sh script.

  1. The downloaded zip archive of the master branch is not a git repository anymore
  2. The environment that extracts, configures and builds it, does not have a git client at hand or even an open routet to the internet

@k-takata
Copy link
Member

k-takata commented Mar 8, 2019

I created a PR #2035.

@Myz
Copy link
Contributor Author

Myz commented Mar 8, 2019

I would appreciate the changes from PR #2035. Like this I would be able to build it again.

@k-takata
Copy link
Member

I think now we can close this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants