feat(#10): Add same Textmate Bundle as VSCode-Extension #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinsefcik
approved these changes
Jul 10, 2024
| // Set the JVM compatibility versions | ||
| withType<JavaCompile> { | ||
| sourceCompatibility = "11" | ||
| targetCompatibility = "11" | ||
| } | ||
|
|
||
| patchPluginXml { | ||
| sinceBuild.set("221") |
There was a problem hiding this comment.
It's not compatible with this version anymore ?
Comment on lines
41
to
42
| sourceCompatibility = "11" | ||
| targetCompatibility = "11" |
There was a problem hiding this comment.
Probably it would be fine to upgrade it to v17 as there is the following warning:
The Java configuration specifies sourceCompatibility=11 but IntelliJ Platform 2024.1 requires sourceCompatibility=17.
during building plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10
This PR adds exactly the same TextMate Bundle used by the VSCode Plugin. To sync changes, a gradle copy task is used to import the required Configuration and Grammar files.
Unfortunately, the
textmate.bundleProvider-Extension Point is only available from the recent 24.1-Version of the TextMate-Plugin that is bundled with IntelliJ, so I increased the minimum supported Version of the Bruno IntelliJ Plugin to the recent 24.1 Version.