fix: correct file icon for nested extensions #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismailshak
added a commit
to ismailshak/nvim
that referenced
this pull request
Feb 18, 2024
Temporary fork with the fix. Upstream PR: utilyre/barbecue.nvim#100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method for getting the icon for a file doesn't account for nested file extensions
An example of this is
some-file.test.ts. The current implementation will only loadtsicons but will miss the icon fortest.ts.Before fix:
After fix:
The screenshots were testing the default
nvim-web-deviconsset fortest.tsvs.tsWe could make this more future-proof by recursively testing the nested extensions against the list of icons provided by
nvim-web-devicons, but I couldn't think of a use case for this so opted out of supporting that just in case it was overkillEDIT: oh hey, 100th PR 🎈 lol