Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: synchronize file type icons with background #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ismailshak
Copy link
Contributor

@ismailshak ismailshak commented Apr 1, 2024

Since we're building a cache of icons for each file type, it prevents the icon from picking a new color when the background has been toggled between light and dark. I prefer/use color schemes that have dynamic highlighting based on background, and tend to toggle between them a lot depending on how bright it is around my monitor.

This PR makes the icon's color able to invalidate the cache

Comparing icons using default icon color

These are the correct colors for the OCaml icon as defined by the nvim-web-devicons spec, for each background;

image image

This is how they render if I toggle the background without restarting neovim. I launched in light mode, then toggled to dark;

image image

@ismailshak ismailshak marked this pull request as ready for review April 1, 2024 00:46
@ismailshak ismailshak force-pushed the feature/synchronize-icons-with-background branch 4 times, most recently from 3cdafea to 654a9c2 Compare April 1, 2024 10:05
@ismailshak ismailshak force-pushed the feature/synchronize-icons-with-background branch from 654a9c2 to 25b724b Compare April 1, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant