Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seq panics with no arguments #4749

Closed
NikolaiSch opened this issue Apr 19, 2023 · 0 comments · Fixed by #4750
Closed

seq panics with no arguments #4749

NikolaiSch opened this issue Apr 19, 2023 · 0 comments · Fixed by #4750
Labels
U - seq

Comments

@NikolaiSch
Copy link

the program panics on line 66 as its unwrapping a none value.

64    let numbers = matches
65          .get_many::<String>(ARG_NUMBERS)
66          .unwrap()
67          .collect::<Vec<_>>();

I will submit a pull request shortly, but should I create an error for this case, and check instead of unwrapping?
@NikolaiSch NikolaiSch mentioned this issue Apr 19, 2023
Merged
@cakebaker cakebaker linked a pull request Apr 19, 2023 that will close this issue
fix: seq panic on no arguments #4749 #4750
Merged
cakebaker added a commit that referenced this issue Jul 9, 2023
@cakebaker
Merge pull request #4750 from NikolaiSch/seq-panic-fix
f8a9552 
fix: seq panic on no arguments #4749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
U - seq
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: seq panic on no arguments #4749 NikolaiSch/coreutils
2 participants
@cakebaker @NikolaiSch