-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/common/util.rs panics with Broken pipe error on some targets when pipe_in() is used in tests #5338
Comments
Hmm, what would we then do in the error branch? I guess we could ignore the error, but that shouldn't be necessary. Which targets are impacted by this? |
yes, specifically for broken pipe - ignore it. Panic on the other errors. Targets where it failed consistently are ubuntu-latest intel (i686, x84_64). All other targets did not fail on the same tests. The workaround is to use Example: https:/uutils/coreutils/actions/runs/6342269393/job/17227755302 |
coreutils/tests/common/util.rs
Lines 2014 to 2015 in aa0437c
This seems to be the culprit. Maybe add handling the errors with match/if let instead of expect().unwrap() ?
The text was updated successfully, but these errors were encountered: