-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort: unknown lint clippy::suspicious_open_options on OpenBSD #6290
Comments
This feels kind of like something we could just ignore for now. With clippy we just follow stable and even with this warning it still compiles and they might even upgrade fairly soon and then the warning will disappear. |
I'm working to add CI for OpenBSD, based on vmactions/openbsd-vm. This action uses OpenBSD stable (current = 7.5) version.
To have a working "Style/Lint" job on OpenBSD, I need to disable I will push a PR to fix this issue (tested on OpenBSD and FreeBSD in my forked repo). |
- Avoid error on OpenBSD stable/7.5 with clippy (lint) - suspicious_open_options added in Rust 1.77.0 (1.76 used on OpenBSD 7.5) https://rust-lang.github.io/rust-clippy/master/index.html#/suspicious_open_options Fix uutils#6290 Signed-off-by: Laurent Cheylus <[email protected]>
On OpenBSD stable (current version 7.5), Rust version = 1.76.0
During CI lint with
cargo clippy
, I have the errorunknown lint: clippy::suspicious_open_options
insrc/uu/sort/src/sort.rs
, line 254.Indeed, the check for
suspicious_open_options
is supported only with Rust >= 1.77.0 => https://rust-lang.github.io/rust-clippy/master/index.html#/suspicious_open_optionsOn OpenBSD 7.5 with Rust 1.76, this check must be disabled in
src/uu/sort/src/sort.rs
.The text was updated successfully, but these errors were encountered: