Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join: fix default check order behaviour #2908

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

cohosh
Copy link
Contributor

@cohosh cohosh commented Jan 22, 2022

If neither --nocheck-order or --check-order are specified, only fail on
unsorted inputs if either file contains unpaired lines.

To quote the relevant lines from info join:

   If the ‘--check-order’ option is given, unsorted inputs will cause a
fatal error message.  If the option ‘--nocheck-order’ is given, unsorted
inputs will never cause an error message.  If neither of these options
is given, wrongly sorted inputs are diagnosed only if an input file is
found to contain unpairable lines, and when both input files are non
empty.  If an input file is diagnosed as being unsorted, the ‘join’
command will exit with a nonzero status (and the output should not be
used).

This fixes a bunch of the remaining failing tests in #2634 including chkodr-4, chkodr-7, chkodr-5d, chkodr-5e, and for some reason 10b.

If neither --nocheck-order or --check-order are specified, only fail on
unsorted inputs if either file contains unpaired lines.
@jtracey jtracey mentioned this pull request Jan 22, 2022
10 tasks
@sylvestre sylvestre merged commit 1415ebc into uutils:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants