printf - Update %g formatting to match GNU #3087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2775.
This format is unintuitive. Uutils previously had
%g
return either the standard%f
output or scientific notation, whichever was shorter. This seems to be a common summary of the format, but it doesn't fully explain its behavior. For example,printf %g 1.234567
prints1.23457
, while%f
prints1.234567
.This PR changes the definition to apply three rules:
I’ve added several tests to validate these rules, and confirmed that GNU gives the same results for each test.
There are probably better ways to write some of this string parsing. I’m still a bit perplexed by Rust’s complex string rules, so I’d appreciate any feedback or cleanup!