Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nproc: Improve the GNU compat #3248

Merged
merged 2 commits into from
Mar 14, 2022
Merged

nproc: Improve the GNU compat #3248

merged 2 commits into from
Mar 14, 2022

Conversation

sylvestre
Copy link
Contributor

It should fix one of the GNU test

@sylvestre
Copy link
Contributor Author

Work at expected, next:

2022-03-12T19:15:59.3639892Z nproc: '-1' is not a valid number: invalid digit found in string
2022-03-12T19:15:59.3640117Z nproc: 'N' is not a valid number: invalid digit found in string

@sylvestre sylvestre changed the title nproc: support --ignore=' 1' as GNU nproc: Improve the GNU compat Mar 13, 2022
@sylvestre
Copy link
Contributor Author

Warning: Congrats! The gnu test tests/misc/nproc-positive is now passing!

tertsdiepraam
tertsdiepraam reviewed Mar 13, 2022
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not merging because the CI is not done, but this makes a lot of sense and looks good

@sylvestre sylvestre merged commit dd6d29f into uutils:main Mar 14, 2022
@sylvestre sylvestre deleted the nproc branch March 14, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @tertsdiepraam