mv: add OverwriteMode match in specific case #3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a test? Thanks |
I added an assert within the mv_errors test |
added 2 commits
April 12, 2022 09:28
Check OverwriteMode and act depending on its value, specifically in the the case of overwriting a non-directory with a directory(#3337)
test -i flag in case of overwriting a non-directory with a directory
|
|
sylvestre
reviewed
Apr 12, 2022
| // $ at.mkdir dir && at.touch file | ||
| // $ mv -i dir file | ||
| // err == mv: cannot overwrite non-directory 'file' with directory 'dir' | ||
| assert!(!scene |
There was a problem hiding this comment.
can you please create a separate new test for this?
easier to debug / identify regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check OverwriteMode and act depending on its value, specifically in the
the case of overwriting a non-directory with a directory
fixes #3337