Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uudoc: Don't download the tldr archive automatically #3415

Merged
merged 1 commit into from
Apr 17, 2022

Conversation

tertsdiepraam
Copy link
Member

@tertsdiepraam tertsdiepraam commented Apr 17, 2022

The ureq dependency is causing compilation errors on various platforms (see #3184, #3216, #3375). Hence we remove that dependency and do not automatically download the archive anymore. Instead, we ask the user to download it separately when the archive is not found.

I'll post a PR to coreutils-docs to download the archive in the CI there.

This PR supersedes #3184.

@tertsdiepraam tertsdiepraam changed the title docs: Don't download the tldr archive automatically uudoc: Don't download the tldr archive automatically Apr 17, 2022
The ureq dependency is causing compilation errors on various platforms (see uutils#3184, uutils#3216, uutils#3375). Hence we remove that dependency and do not automatically download the archive anymore. Instead, we ask the user to download it separately when the archive is not found.
@sylvestre
Copy link
Contributor

LGTM, thanks

@sylvestre sylvestre merged commit 62d96db into uutils:main Apr 17, 2022
@sylvestre
Copy link
Contributor

Don't forget about coreutils docs ;)
https://uutils.github.io/coreutils-docs/user/utils/chmod.html

@tertsdiepraam
Copy link
Member Author

Yes, I'll do that today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build cause an error with "ring" macOS m1 pro/max ARM64 binary?
2 participants