-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/util: improve run_ucmd_as_root
for CICD
#3518
Conversation
add feature for `whoami`
… run_ucmd_as_root
I guess you saw: |
dd79569
to
b7ac851
Compare
Ah okay, I'll try to investigate that |
c6e68d6
to
a00d5df
Compare
* ensure that `fn run_no_wait` is only invoked if the system running the test has `sudo` in $path Previously, if run inside CICD, calling `fn run_ucmd_as_root` would provoke `fn run_no_wait` to panic because there's no `sudo`.
a00d5df
to
12d7d98
Compare
So, I guess the failure
is unrelated? |
I have seen some unexpected behavior too in the past |
Yes, that looks like an unrelated glitch. |
The documentation for GitHub Actions states that So something odd is happening. Maybe |
Ensure that
fn run_no_wait
is only invoked if the system running thetest has
sudo
in $pathPreviously, if run inside CICD, calling
fn run_ucmd_as_root
would provoke
fn run_no_wait
to panic because there's nosudo
.Can be tested locally with:
(I don't know why all the old commits popped up here !?)