chroot: set trailing var arg
#3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, I think this needs a slightly different approach (though still one line). Ill update the PR soon. |
Without trailing var arg set in clap, flags in the command argument are incorrectly parsed by clap.
tertsdiepraam
force-pushed
the
chroot-allow-hyphen-values
branch
from
245ceb5
to
1abfc4b
Compare
tertsdiepraam
changed the title
chroot: allow hyphen values in commandchroot: set trailing var arg
|
I solved it with the |
|
oh, cool, i didn't get this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3783
In the issue the
-cflag should be passed to/bin/shand not be parsed bychroot. This is fixed by simply allowing hyphen values.@Lunarequest, could you verify that this solves the issue?