cp: allow removing symbolic link loop destination #3972
Conversation
jfinkels
force-pushed
the
cp-symbolic-link-loop
branch
2 times, most recently
from
437e2f1
to
ccc3810
Compare
Nice! |
src/uu/cp/src/cp.rs
Outdated
| // because if `path` is a symbolic link and there are too many | ||
| // levels of symbolic link, then those methods will return false | ||
| // or an OS error. | ||
| std::fs::metadata(path) |
There was a problem hiding this comment.
Is this not functionally the same as just using symlink_metadata? Because if the path is not a link, they are the same and if it is a link, then symlink_metadata should return Ok in a superset of the cases of metadata, right?
fn file_or_link_exists(path: &Path) -> bool {
path.symlink_metadata().is_ok()
}There was a problem hiding this comment.
I think you might be right. I'll update it.
jfinkels
force-pushed
the
cp-symbolic-link-loop
branch
from
ccc3810
to
aad3202
Compare
Allow `cp --remove-destination` to remove a symbolic link loop (or a
symbolic link that initiates a chain of too many symbolic
links). Before this commit, if `loop` were a symbolic link to itself,
then
cp --remove-destination file loop
would fail with an error message. After this commit, it succeeds. This
matches the behaviotr of GNU cp.
sylvestre
force-pushed
the
cp-symbolic-link-loop
branch
from
aad3202
to
24630db
Compare
|
Congrats! The gnu test tests/misc/tee is no longer failing! |
|
cool: |
Allow
cp --remove-destinationto remove a symbolic link loop (or a symbolic link that initiates a chain of too many symbolic links). Before this commit, ifloopwere a symbolic link to itself, thenwould fail with an error message. After this commit, it succeeds. This matches the behaviotr of GNU cp.
This should make the GNU test suite file
tests/cp/dir-rm-dest.shpass.