rm: rm3.sh now passes #4008
Closed
rm: rm3.sh now passes #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
palaster
commented
Oct 6, 2022
palaster
commented
- Changed the use of hard-coded prompts messages to use uucore::util_name instead
- Rewrote prompt_write_protected and prompt_file into a single function prompt_file because I a lot of the code was being reused for both
sylvestre
reviewed
Oct 6, 2022
src/uu/rm/src/rm.rs
Outdated
| remove_file(file, options) | ||
| } else { | ||
| match file.metadata() { |
There was a problem hiding this comment.
please add a comment explaining in which case we are here
sylvestre
reviewed
Oct 6, 2022
src/uu/rm/src/rm.rs
Outdated
| remove_file(file, options) | ||
| } | ||
| } | ||
| Err(_e) => { |
There was a problem hiding this comment.
please add a test to cover this case
There was a problem hiding this comment.
There is already a test for it: test_rm::test_rm_symlink_dir() and test_rm::test_rm_invalid_symlink()
There was a problem hiding this comment.
the code coverage results don't agree ;)
sylvestre
requested changes
Oct 6, 2022
Generating the tests to run in build.rs created problems for tooling. For example, cargo fmt, was ignoring the test_*.rs files and needed to be passed these files manually to be formatted. Now we simply use the feature mechanism to decide which tests to run.
Correct the error message produced when attempting to copy a directory
into itself with `cp`. Before this commit, the error message was
$ cp -R d d
cp: cannot copy a directory, 'd', into itself, 'd'
After this commit, the error message is
$ cp -R d d
cp: cannot copy a directory, 'd', into itself, 'd/d'
Move the copy-on-write functions for `cp` to their own module. This provides a layer of indirection so that the `cp.rs` module need only use `platform::copy_on_write()`, and the `platform` module is responsible for providing the appropriate implementation for the current platform. This commit does not change the behavior of the code, just its organization.
This commit now allows split to pass split/numeric.sh
|
Broke branch will have to make a new one: new one here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.