tail: Refactor handling of warnings and early exits
#4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Joining7943
force-pushed
the
refactor-tail-check-warnings
branch
from
c14247c
to
bb48e63
Compare
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
|
Sorry, that the tests for the warnings aren't integrated right now. But, I've ran the tests against the last 3 commits locally, so these changes are most probably working. We'll see this hopefully soon also in in the ci. |
|
GNU testsuite comparison: |
Joining7943
force-pushed
the
refactor-tail-check-warnings
branch
from
4d69b80
to
fc0cf03
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Joining7943
force-pushed
the
refactor-tail-check-warnings
branch
from
084037f
to
e7b6568
Compare
|
GNU testsuite comparison: |
|
I've added all additional tests written during the refactoring of tail. These include the tests for the warnings. A lot of these additional tests (besides the warnings tests) are currently (partly) disabled and only show the bugs and wrong behavior if enabled. I could fix many of them on the way of #3952 and they are therefore enabled there. |
Joining7943
added a commit
to Joining7943/uutil-coreutils
that referenced
this pull request
Dec 7, 2022
…to reflect current development state.
Joining7943
force-pushed
the
refactor-tail-check-warnings
branch
from
e7b6568
to
2cedc72
Compare
Joining7943
added a commit
to Joining7943/uutil-coreutils
that referenced
this pull request
Dec 7, 2022
…to reflect current development state.
|
GNU testsuite comparison: |
Joining7943
force-pushed
the
refactor-tail-check-warnings
branch
2 times, most recently
from
6156597
to
8958e82
Compare
Joining7943
changed the title
tail: Refactor handling of warnings and early exits
|
@tertsdiepraam ping :) i think this pr would be ready for a final review. |
Joining7943
force-pushed
the
refactor-tail-check-warnings
branch
2 times, most recently
from
fcd92a9
to
b4bc6ad
Compare
|
Are we ready, here? |
…InputService ... Other changes summary: * Cleanup imports * Remove stdin_is_pipe_of_fifo function * Rename WatcherService to Observer
…d support set to 0 in Observer.
…from tip of refactoring branch Other changes summmary: * Use module level imports instead of fully qualified imports where appropriate * Fix intermittent failing test_positive_zero_bytes because of broken pipe * Cleanup old disabled test for warning of following indefinitely
Joining7943
force-pushed
the
refactor-tail-check-warnings
branch
from
b4bc6ad
to
b339f6d
Compare
|
GNU testsuite comparison: |
tertsdiepraam
approved these changes
Dec 14, 2022
|
Very nice! |
Joining7943
added a commit
to Joining7943/uutil-coreutils
that referenced
this pull request
Jan 7, 2023
…to reflect current development state.
Joining7943
added a commit
to Joining7943/uutil-coreutils
that referenced
this pull request
Feb 18, 2023
…to reflect current development state.
Joining7943
added a commit
to Joining7943/uutil-coreutils
that referenced
this pull request
Apr 2, 2023
…to reflect current development state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
This pr also adds the missing warning because of
--followbeing ineffective under some special circumstances.The warnings and early exits are organized in dedidacted methods within the
Settingsstruct providing:args::Settings::fromhas no side effects anymore and the methods sole purpose is parsing and storing the initial configuration provided by the usertailtailThis pr also adds more tests which originate from the main refactoring pr #3952. A lot of these tests (besides the ones testing the
warningfunctionality) show some broken functionality oftailor a bug and are therefore (partly)disabled_until_fixed, here. However, many of them were fixed on the way of #3952 and are enabled there.There's also some additional code cleanup:
InputServiceand move some of its functionality intoSettingsstdin_is_pipe_of_fifofunction