Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV 1.64 & Workspace inheritance for dependencies #4344

Merged
merged 4 commits into from
Feb 12, 2023

Conversation

tertsdiepraam
Copy link
Member

@tertsdiepraam tertsdiepraam commented Feb 11, 2023

The first two commits are just bumping the MSRV and fixing the clippy lints.

The last commit is more involved. I'm using the new workspace inheritance method for declaring dependencies. This means that we have a global list of dependencies in the root Cargo.toml that the other crates refer to. If we then want to, for example, bump the version a dependency, we only need to change the version in root Cargo.toml. I think it also creates a clear overview of (almost) all dependencies in the project. There were also many dependencies for which the spec was outdated or where one crate specified it as "0.2" and another as "0.2.3".

I can remove this last commit if you want, but I think it's useful. @sylvestre

@tertsdiepraam tertsdiepraam linked an issue Feb 11, 2023 that may be closed by this pull request
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/tee is no longer failing!
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/tee is no longer failing!
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@sylvestre
Copy link
Contributor

So much better, it will make our life much easier :)
many thanks

@sylvestre sylvestre merged commit 816e0d5 into uutils:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump MSRV to 1.64?
2 participants