Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dd: move dd_out() function up to module level #4428

Merged
merged 2 commits into from
Feb 24, 2023
Merged

dd: move dd_out() function up to module level #4428

merged 2 commits into from
Feb 24, 2023

Commits on Feb 24, 2023

  1. dd: move finalize() function to module level 

    Move the `finalize()` function out of the `impl Output` block and up
to the module level so that it can be accessed by other module-level
functions.
    @jfinkels
    jfinkels committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    3faf642 View commit details
    Browse the repository at this point in the history

  2. dd: move dd_out() function up to module level 

    Move the `dd_out()` function out of the `impl Output` and up to the
module level, renaming it to `dd_copy()`. This change aligns it with
the pattern set by `std::io::copy()`, which similarly takes an input
reader and an output writer.

This does not change the behavior of `dd`, just the code organization
to make it more closely match the idioms in the Rust standard library.
    @jfinkels
    jfinkels committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    b9003d1 View commit details
    Browse the repository at this point in the history