sleep: Replace uucore::parse_time::from_str with fundu
#4448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as draft because of the dependency between the two PRs. You can mark it ready again when the other PR is merged :) |
Joining7943
force-pushed
the
sleep-replace-uucore-from-str-with-fundu
branch
2 times, most recently
from
ddd3069
to
ff70ca5
Compare
src/uu/sleep/src/sleep.rs
Outdated
| ParseError::Syntax(pos, description) | ||
| | ParseError::TimeUnit(pos, description) => format!( | ||
| "{description} at position {}", | ||
| pos.checked_add(1).unwrap_or(pos) |
There was a problem hiding this comment.
Nit: This is just a saturating_add isn't it?
There was a problem hiding this comment.
oh yes, I'll change it to saturating_add!
Nice! I'll update the branch to get rid of the clippy warnings.
Thanks!
There was a problem hiding this comment.
I rebased onto main after this change, so the merge commit is gone again.
Joining7943
force-pushed
the
sleep-replace-uucore-from-str-with-fundu
branch
from
7614cc2
to
5fb091a
Compare
|
GNU testsuite comparison: |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also https:/Joining7943/fundu. This pr also improves the error messages.
This pr depends on #4439