parser: fix index out of bounds error

[papparapa]

Fixes #4479

This PR fixes index out of bounds in parse_glob::fix_negation.

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!
GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

[sylvestre]

Could you please add a test to make sure we don't regress in the future?

[sylvestre]

(thanks ;)

[tertsdiepraam]

Great find! In addition to the test, could you add a comment explaining what the offset is for?

[sylvestre]

I landed the fuzzers and rebuild on top of this PR and we are getting:

thread '<unnamed>' panicked at 'index out of bounds: the len is 11 but the index is 11', /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uucore-0.0.17/src/lib/parser/parse_glob.rs:14:54

[papparapa]

Added a comment and a test.

@sylvestre

I landed the fuzzers and rebuild on top of this PR and we are getting:

thread '<unnamed>' panicked at 'index out of bounds: the len is 11 but the index is 11', /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/uucore-0.0.17/src/lib/parser/parse_glob.rs:14:54

Did it use the old file in cargo registry?

[sylvestre]

yeah, i guess it was the issue
i saw that you are not using the workspace too (i did it here too: #4495 )
it is clearly fixed:
https:/uutils/coreutils/actions/runs/4384176388/jobs/7675329815
Done 1439932 runs in 61 second(s)
bravo