Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashsum: add --zero option (#4612) #4632

Merged
merged 6 commits into from
Mar 28, 2023
Merged

hashsum: add --zero option (#4612) #4632

merged 6 commits into from
Mar 28, 2023

Conversation

0xMRTT
Copy link
Contributor

@0xMRTT 0xMRTT commented Mar 25, 2023 •
edited
Loading 

$ touch a
$ ./target/debug/coreutils md5sum --zero a

returns

d41d8cd98f00b204e9800998ecf8427e  a%

With GNU:

$ /usr/bin/md5sum --zero  a
d41d8cd98f00b204e9800998ecf8427e  a%

@0xMRTT
Copy link
Contributor Author

0xMRTT commented Mar 25, 2023

@tertsdiepraam Made a dumb error, now that's should be good...

@sylvestre
Copy link
Contributor

Could you please add a test?

@0xMRTT
Copy link
Contributor Author

0xMRTT commented Mar 25, 2023

Sure

sylvestre
sylvestre reviewed Mar 25, 2023
View reviewed changes
tests/by-util/test_hashsum.rs Outdated
@@ -52,6 +52,14 @@ macro_rules! test_digest {
.no_stderr()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run rustfmt on the test too

@sylvestre sylvestre mentioned this pull request Mar 27, 2023
Closed
sylvestre
sylvestre requested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rustfmt

@cakebaker cakebaker linked an issue Mar 28, 2023 that may be closed by this pull request
md5sum --zero isn't implemented #4612
Closed
@sylvestre sylvestre merged commit e7ef9dc into uutils:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

md5sum --zero isn't implemented
2 participants
@0xMRTT @sylvestre