Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

du: threshold error message fix #4637

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Conversation

haciek
Copy link
Contributor

@haciek haciek commented Mar 25, 2023

This pull requests adds an error message to the --threshold option inline with the GNU version of du.

Previous behavior:

$ du --threshold -0 file
0	file

Current behavior:

$ du --threshold -0 file
du: invalid --threshold argument '-0'

Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a straightforward fix. Thanks!

src/uu/du/src/du.rs Show resolved Hide resolved
@sylvestre
Copy link
Contributor

and please add a test to make sure we don't regress in the future, thanks

@sylvestre
Copy link
Contributor

please run rustfmt on both files
thanks

src/uu/du/src/du.rs Outdated Show resolved Hide resolved
src/uu/du/src/du.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@cakebaker cakebaker linked an issue Mar 27, 2023 that may be closed by this pull request
@cakebaker cakebaker merged commit 089e645 into uutils:main Mar 27, 2023
@cakebaker
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"du --threshold=-0" should generate an error
4 participants