Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.0.17 => 0.0.18 #4639

Merged
merged 1 commit into from
Apr 2, 2023
Merged

0.0.17 => 0.0.18 #4639

merged 1 commit into from
Apr 2, 2023

Conversation

sylvestre
Copy link
Contributor

No description provided.

@anastygnome
Copy link
Contributor

From the time changelog

  • An API has been added to opt out of soundness checks for obtaining the local offset. This replaces
    the previous, officially unsupported RUSTFLAGS="--cfg unsound_local_offset". End users may call
    time::util::local_offset::set_soundness(time::util::local_offset::Soundness::Unsound). This
    method is unsafe because it enables undefined behavior if its safety requirements are not
    upheld. Note that libraries must not set this to Unsound, as it is impossible for a library
    to guarantee end users uphold the required invariants.

@sylvestre
Copy link
Contributor Author

yeah, not sure how to fix that :/

@tertsdiepraam
Copy link
Member

It's because you updated cargo lock I believe. We've seen this before here: #4489

@sylvestre
Copy link
Contributor Author

sylvestre commented Mar 26, 2023

yeah, my point was more "how do we fix this specific issue" :)

i updated cargo.lock because one of the jobs was complaining. I will have a look to the cargo.lock issue

@tertsdiepraam
Copy link
Member

I think I fixed it (at least it works locally), but I put it in a separate PR, so we can see the CI results first.

@anastygnome
Copy link
Contributor

@tertsdiepraam apparently the android CI complains rust & cargo aren't installed.
Maybe we should modify the script in another PR?

@uutils uutils deleted a comment from github-actions bot Apr 2, 2023
@uutils uutils deleted a comment from github-actions bot Apr 2, 2023
@sylvestre sylvestre merged commit 3247e1b into uutils:main Apr 2, 2023
@sylvestre sylvestre deleted the version branch April 2, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants