Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: compute individual binary sizes #4694

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

miles170
Copy link
Contributor

@miles170 miles170 commented Mar 31, 2023

We need this PR to be merged before checking the binary size. See #4693

@miles170 miles170 force-pushed the ci-compute-individual-binary-sizes branch 2 times, most recently from 4dcd846 to d02302a Compare March 31, 2023 06:46
@miles170 miles170 force-pushed the ci-compute-individual-binary-sizes branch from d02302a to faf9a7f Compare April 3, 2023 07:54
@sylvestre
Copy link
Contributor

A few comments

  • Looks like they all have the same sha:

  • could you please sort the program by order ?

  • could you please store the size in byte ? (I guess it is kb here)

    "tr": {
    "sha": "ff3a35bb658665667961061acafeff72ea9230be",
    "size": 784
    },
    "tee": {
    "sha": "ff3a35bb658665667961061acafeff72ea9230be",
    "size": 744
    },
    "cp": {
    "sha": "ff3a35bb658665667961061acafeff72ea9230be",
    "size": 1048
    },

@miles170
Copy link
Contributor Author

miles170 commented Apr 4, 2023

A few comments

  • Looks like they all have the same sha:
  • could you please sort the program by order ?
  • could you please store the size in byte ? (I guess it is kb here)
    "tr": {
    "sha": "ff3a35bb658665667961061acafeff72ea9230be",
    "size": 784
    },
    "tee": {
    "sha": "ff3a35bb658665667961061acafeff72ea9230be",
    "size": 744
    },
    "cp": {
    "sha": "ff3a35bb658665667961061acafeff72ea9230be",
    "size": 1048
    },
  1. Would you want me to put sha in top order? Something like the following
"sha": "ff3a35bb658665667961061acafeff72ea9230be",
"tr": 784,
"tee": 744,
"cp": 1048,
  1. Should I also change the size-result.json size unit to byte?

@sylvestre
Copy link
Contributor

ok, let's keep kbyte then, sorry

I thought it was the hash of the binary. not the commit hash. So, yeah, your plan looks great.

@miles170 miles170 force-pushed the ci-compute-individual-binary-sizes branch from faf9a7f to 748440b Compare April 4, 2023 12:47
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@miles170 miles170 requested a review from sylvestre April 14, 2023 14:40
@miles170 miles170 force-pushed the ci-compute-individual-binary-sizes branch from 748440b to 0631890 Compare April 14, 2023 14:40
@sylvestre
Copy link
Contributor

I still see the sha for each program

"arch": {
  "sha": "8e7143d503f701e2d5bc6b9c3fe475ac459a9e9f",
  "size": 684
},

@miles170
Copy link
Contributor Author

I still see the sha for each program

"arch": {
  "sha": "8e7143d503f701e2d5bc6b9c3fe475ac459a9e9f",
  "size": 684
},

I apologize for my carelessness.

@miles170 miles170 force-pushed the ci-compute-individual-binary-sizes branch 3 times, most recently from 0cc91b8 to 16cc88b Compare April 15, 2023 09:41
@miles170 miles170 force-pushed the ci-compute-individual-binary-sizes branch from 16cc88b to 699c1d5 Compare April 15, 2023 10:45
@sylvestre
Copy link
Contributor

perfect, thanks

{
  "Sat, 15 Apr 2023 11:21:58 +0000": {
    "sha": "eafa220845212a6393008b419ff063b70e5d3175",
    "sizes": {
      "[": 724,
      "arch": 684,
      "base32": 808,
      "base64": 808,
      "basename": 708,
      "basenc": 820,
      "cat": 736,
      "chgrp": 776,
      "chmod": 740,
      "chown": 784,
[...]

@uutils uutils deleted a comment from github-actions bot Apr 16, 2023
@uutils uutils deleted a comment from github-actions bot Apr 16, 2023
@sylvestre
Copy link
Contributor

it would be nice to graph the evolution of each binaries over time :)
https:/uutils/coreutils-tracking

@miles170
Copy link
Contributor Author

it would be nice to graph the evolution of each binaries over time :) https:/uutils/coreutils-tracking

I can work on this.

@sylvestre sylvestre merged commit 4e23b33 into uutils:main Apr 17, 2023
@miles170 miles170 deleted the ci-compute-individual-binary-sizes branch April 17, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants