Reduce cognitive complexity: just move some of the contents in functions #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
reviewed
Apr 17, 2023
| /// # Panics | ||
| /// | ||
| /// Panics if multiple hash algorithms are specified or if a required flag is missing. | ||
| fn create_algorithm_from_flags(matches: &ArgMatches) -> (&'static str, Box<dyn Digest>, usize) { |
There was a problem hiding this comment.
For consistency reasons I would either rename this function to create_algo_from_flags or rename the existing function detect_algo to detect_algorithm
cakebaker
reviewed
Apr 17, 2023
cakebaker
reviewed
Apr 17, 2023
cakebaker
reviewed
Apr 17, 2023
src/uu/install/src/install.rs
Outdated
| /// | ||
| /// Returns an empty Result or an error in case of failure. | ||
| /// | ||
| fn strip_file(to: &Path, b: &Behavior) -> UResult<()> { | ||
| if b.strip && cfg!(not(windows)) { |
There was a problem hiding this comment.
I would move if b.strip to the copy function and replace cfg!(not(windows)) with #[cfg(not(windows))].
There was a problem hiding this comment.
much better, thanks
sylvestre
force-pushed
the
cognitive_complexity
branch
from
e44a8d5
to
25fbcd8
Compare
cakebaker
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.