mv: check if --target is a directory

[shinhs0506]

should fix mv/diag.sh

[sylvestre]

Still fails it seems:

2023-04-26T19:10:55.8539986Z FAIL: tests/mv/diag
2023-04-26T19:10:55.8540067Z ===================
2023-04-26T19:10:55.8540074Z 
2023-04-26T19:10:55.8540249Z --- exp	2023-04-26 19:00:50.588473849 +0000
2023-04-26T19:10:55.8540423Z +++ out	2023-04-26 19:00:50.588473849 +0000
2023-04-26T19:10:55.8540548Z @@ -1,6 +1,17 @@
2023-04-26T19:10:55.8540690Z -mv: missing file operand
2023-04-26T19:10:55.8541018Z -Try 'mv --help' for more information.
2023-04-26T19:10:55.8541226Z -mv: missing destination file operand after 'no-file'
2023-04-26T19:10:55.8541392Z -Try 'mv --help' for more information.
2023-04-26T19:10:55.8541705Z +error: the following required arguments were not provided:
2023-04-26T19:10:55.8541797Z +  <files>...
2023-04-26T19:10:55.8541872Z +
2023-04-26T19:10:55.8542049Z +Usage: mv [OPTION]... [-T] SOURCE DEST
2023-04-26T19:10:55.8542165Z +       mv [OPTION]... SOURCE... DIRECTORY
2023-04-26T19:10:55.8542345Z +       mv [OPTION]... -t DIRECTORY SOURCE...
2023-04-26T19:10:55.8542418Z +
2023-04-26T19:10:55.8542585Z +For more information, try '--help'.
2023-04-26T19:10:55.8543197Z +error: The argument '<files>...' requires at least 2 values, but only 1 was provided
2023-04-26T19:10:55.8543255Z +
2023-04-26T19:10:55.8543427Z +Usage: mv [OPTION]... [-T] SOURCE DEST
2023-04-26T19:10:55.8543538Z +       mv [OPTION]... SOURCE... DIRECTORY
2023-04-26T19:10:55.8543719Z +       mv [OPTION]... -t DIRECTORY SOURCE...
2023-04-26T19:10:55.8543792Z +
2023-04-26T19:10:55.8543956Z +For more information, try '--help'.
2023-04-26T19:10:55.8544108Z  mv: target 'f1': Not a directory
2023-04-26T19:10:55.8544288Z  mv: target directory 'f2': Not a directory

[shinhs0506]

yep still working on it

[shinhs0506]

@sylvestre our program is outputting more error messages than it should (although still helpful) do we try to fix those as well?
this pr still fixes the last 2 lines of the error messages in the screenshot.

[cakebaker]

Can you please add a test to tests/by-util/test-mv.rs so we don't regress in the future?

[cakebaker]

This is a hack ;-) When reading this snippet, I translate it to "If it's a target directory, return a 'Target is not a directory' error".

I think the TargetNotADirectory error should be returned from where the cli args are processed.

[cakebaker]

Thanks for adding the tests, great work!

[sylvestre]

@shinhs0506 please don't use screenshot. they are terrible for accessibility and search

To answer to your question, as clap is usually giving excellent error, we adjust the GNU test to match our.
Example:
https:/uutils/coreutils/blob/main/util/build-gnu.sh#L223

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/mv/diag is no longer failing!

[sylvestre]

Congrats! The gnu test tests/mv/diag is no longer failing!
bravo :)

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/mv/diag is no longer failing!
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?