android: use cargo test instead of nextest #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextest does build because of: 2023-04-29T08:03:36.5411530Z Compiling log v0.4.17 2023-04-29T08:03:36.5412100Z error[E0432]: unresolved import linux_raw_sys::ioctl 2023-04-29T08:03:36.5412710Z --> /data/data/com.termux/files/home/.cargo/registry/src/github.com-1285ae84e5963aae/rustix-0.37.17/src/backend/libc/io/syscalls.rs:384:24 2023-04-29T08:03:36.5413150Z | 2023-04-29T08:03:36.5413830Z 384 | use linux_raw_sys::ioctl::EXT4_IOC_RESIZE_FS; 2023-04-29T08:03:36.5414380Z | could not find ioctl in linux_raw_sys 2023-04-29T08:03:36.5414590Z 2023-04-29T08:03:36.5414840Z For more information about this error, try rustc --explain E0432. 2023-04-29T08:03:36.5415280Z error: could not compile rustix due to previous error 2023-04-29T08:03:36.5415730Z warning: build failed, waiting for other jobs to finish... nextest-rs/nextest#862
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 29, 2023
util/android-commands.sh
Outdated
| @@ -209,7 +210,7 @@ snapshot() { | |||
| # We need to install nextest via cargo currently, since there is no pre-built binary for android x86 | |||
| command="'\ | |||
| export CARGO_TERM_COLOR=always; \ | |||
| cargo install cargo-nextest; \ | |||
| #cargo install cargo-nextest; \ | |||
There was a problem hiding this comment.
Is the rest of this block still necessary? It might also be useful to add a hint why it is commented out.
…ash_dash on android
…rg_interactive_update on android
|
it is green most of the time now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextest does build because of:
nextest-rs/nextest#862