Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests/mv/i-5.sh #4823

Merged
merged 2 commits into from
May 4, 2023
Merged

fix tests/mv/i-5.sh #4823

merged 2 commits into from
May 4, 2023

Conversation

shinhs0506
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented May 4, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/mv/i-5 is no longer failing!
Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@sylvestre
Copy link
Contributor

I think your test needs to be updated:

--- TRY 3 STDERR:        coreutils::tests test_mv::test_mv_interactive_dir_to_file_not_affirmative ---
thread 'test_mv::test_mv_interactive_dir_to_file_not_affirmative' panicked at 'Expected stderr to be empty, but it's:
mv: overwrite 'test_mv_interactive_dir_to_file_not_affirmative_file'?  ', tests/by-util/test_mv.rs:278:10
stack backtrace:
   0: rust_begin_unwind
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/panicking.rs:142:14
   2: tests::common::util::CmdResult::no_stderr
             at ./tests/common/util.rs:418:9
   3: tests::test_mv::test_mv_interactive_dir_to_file_not_affirmative
             at ./tests/by-util/test_mv.rs:273:5
   4: tests::test_mv::test_mv_interactive_dir_to_file_not_affirmative::{{closure}}
             at ./tests/by-util/test_mv.rs:264:1
   5: core::ops::function::FnOnce::call_once
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/ops/function.rs:248:5
   6: core::ops::function::FnOnce::call_once
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/ops/function.rs:248:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

@github-actions
Copy link

github-actions bot commented May 4, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/cp/thru-dangling is no longer failing!
Congrats! The gnu test tests/mv/i-5 is no longer failing!
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@cakebaker cakebaker merged commit 4ee1118 into uutils:main May 4, 2023
@cakebaker
Copy link
Contributor

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants