ls: Implement new sort option --sort=width #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Skryptonyte
changed the title
|
Thanks for your PR! Can you please run |
|
Yeah sure thing! Was out for a bit, will it get to it soon. |
cakebaker
reviewed
Jun 6, 2023
|
Right, now it should fall back to alphabetic sorting in those cases. Also extended the test case to check for those as well. |
|
Great work, thanks :) |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was introduced in some more recent versions of GNU coreutils (around 2021-4-11) which lets you sort by filename widths .
One oddity of this particular option in GNU coreutils is that unlike other sort options, this one does not have a shorthand form flag so I have implemented it similarly as such here.