Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkdir: remove TEST_DIR<x> consts in tests #4957

Merged
merged 2 commits into from
Jun 8, 2023
Merged

mkdir: remove TEST_DIR<x> consts in tests #4957

merged 2 commits into from
Jun 8, 2023

Conversation

cakebaker
Copy link
Contributor

This PR removes all TEST_DIR<x> consts to improve the readability of the tests.

tertsdiepraam
tertsdiepraam approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes DRY goes too far :)

@tertsdiepraam
Copy link
Member

Is the mutex still necessary? Every test should run in a separate tmp dir right?

@cakebaker
Copy link
Contributor Author

I think the mutex is still necessary. It was only recently introduced due to some issues caused when setting umask.

@sylvestre sylvestre merged commit c3fcde2 into uutils:main Jun 8, 2023
@cakebaker cakebaker deleted the mkdir_refactor_tests branch June 8, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cakebaker @tertsdiepraam @sylvestre