Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv: fix into-self-2.sh test #4966

Merged
merged 3 commits into from
Jun 11, 2023
Merged

Conversation

Skryptonyte
Copy link
Contributor

In normal GNU mv behaviour, moving a symlink to a file with target as file should fail which this one does currently, but vice versa must actually succeed. I have slightly changed the approach of mv so that when checking for same link, only the source path's symbolic link is resolved fully while target is taken as is which seems to fix some edge cases.

I am a bit unsure of how to handle this on Windows however.

@cakebaker
Copy link
Contributor

You could handle it for Windows in the same way it is done for the are_hardlinks_to_same_file function: a dummy implementation for Windows and a real implementation for Unix.

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/mv/into-self-2 is no longer failing!

@sylvestre sylvestre merged commit 856825b into uutils:main Jun 11, 2023
@sylvestre
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants