rm: make the utility public
#5304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amended the commit and overwrote the source branch to fix the copy paste error. Commit name should be correct now. |
|
|
Made `Options` and `InteractiveMode` public and added documentation for them.
KAAtheWiseGit
changed the title
rm: make the utility public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made
Options,InteractiveMode, and theremovefunction public and added documentation for them. This is an attempt at implementing #5294.rmoptions are much simpler compared tocp, so I just made them public. I am unsure ifOPT_*constants should be made public too.Additionally, I couldn't figure out what
InteractiveMode::PromptProtecteddoes, as it doesn't seem to be used anywhere. So the documentation is a TODO for now.P.S. the commit also includes a minor typo fix:
eay -> way.