Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nl: fix output order if stdin and files are mixed #5306

Merged
merged 1 commit into from
Sep 24, 2023
Merged

nl: fix output order if stdin and files are mixed #5306

merged 1 commit into from
Sep 24, 2023

Conversation

cakebaker
Copy link
Contributor

This PR changes the output order from "files first, stdin last" to "input order = output order" to match the behavior of GNU nl.

tertsdiepraam
tertsdiepraam approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why that behavior was there in the first place. But this is much better!

@tertsdiepraam tertsdiepraam merged commit 4ca792d into uutils:main Sep 24, 2023
43 of 45 checks passed
@cakebaker cakebaker deleted the nl_fix_output_order_if_stdin_and_files_are_mixed branch September 24, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @tertsdiepraam