fuzz: move the common duplicated code into a function #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
reviewed
Sep 28, 2023
fuzz/fuzz_targets/fuzz_test.rs
Outdated
Comment on lines
31
to
34
| static CMD_PATH: &str = "/usr/bin/test"; | ||
|
|
||
| fn run_gnu_test(args: &[OsString]) -> Result<(String, i32), std::io::Error> { | ||
| let mut command = Command::new("test"); | ||
| let mut command = Command::new(CMD_PATH); |
There was a problem hiding this comment.
Is this deliberately done differently than in fuzz_expr.rs? There it is done in the following way:
static CMD_PATH: &str = "expr";
fn run_gnu_expr(args: &[OsString]) -> Result<(String, i32), std::io::Error> {
is_gnu_cmd(CMD_PATH)?; // Check if it's a GNU implementation
let mut command = Command::new(CMD_PATH);There was a problem hiding this comment.
/usr/bin/ is an artifact, i will remove it
and yeah, test --version doesn't return anything :(
so, dunno how to verify that it is the GNU impl
There was a problem hiding this comment.
In the docs they write to use [:
To get help and version information, invoke the commands ‘[ --help’ and ‘[ --version’
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.