Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of nushell/nushell#10447 (comment)
This path makes an iterator interface for
rm
. The iterator is theRemover
type, which yields anUResult<()>
for every file.nushell
can choose to how to print the errors.To achieve that, I had to make every function return errors instead of printing them. This in turn lead to some big refactors for
remove_file
andremove_dir
. I wish there was a better way to write an iterator like this, but I think it turned out alright. Maybe we can clean it up more in the future.Oh and
walkdir
was only getting in the way. So I removed that too.